[IMPROVED] Documentation of jetstream options and Fetch clarification #1770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
piotrpio
force-pushed
the
docs-inprovement
branch
from
ed7e147 to
42660b0
Compare
Jarema
requested changes
Jan 14, 2025
jetstream/jetstream_options.go
Outdated
Comment on lines
107
to
109
| // | ||
| // PullMaxMessages implements PullConsumeOpt and PullMessagesOpt and thus can | ||
| // be used to configure both Consumer.Consume and Consumer.Messages. |
There was a problem hiding this comment.
Suggested change
| // | |
| // PullMaxMessages implements PullConsumeOpt and PullMessagesOpt and thus can | |
| // be used to configure both Consumer.Consume and Consumer.Messages. | |
| // PullMaxMessages implements both PullConsumeOpt and PullMessagesOpt, allowing it to configure Consumer.Consume and Consumer.Messages. |
How about such phrasing?
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1756
Signed-off-by: Piotr Piotrowski piotr@synadia.com