-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Initial implementation of per-key-TTL for KV #703
Conversation
74d3cf9
to
d234060
Compare
we're hoping to merge this into server 2.11 branch before server release #733 |
Can't wait for per-key TTL, it will allow usage of NATS in FusionCache too. Thanks for all the hard work! |
… tests for errors when message TTL is disabled
…ts. Those implementing the interface will still need to make changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks @stebet
There are still details to be worked out e.g. around SubjectDeleteMarkerTTL
but this PR introduces support for per-message/key TTL feature for new server 2.11 soon to be released. We can have follow up PRs into the server-2.11-features branch when we have more implementation details available.
* Initial implementation of per-key-TTL for KV (#703)
* Initial implementation of per-key-TTL for KV (#703)
Note
AllowMsgTTL
flag for KV streamsTimestamp ttl
optional parameter to thePutAsync<T>
method onINatsKVStore
TODO:
CreateAsync/UpdateAsync
API methodssee also ADR-43