Support v2 JS.ACK format #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See nats-io/nats-and-architecture-design#49 Signed-off-by: Byron Ruth <b@devel.io>
10 tasks
Signed-off-by: Byron Ruth <b@devel.io>
Signed-off-by: Byron Ruth <b@devel.io>
Signed-off-by: Byron Ruth <b@devel.io>
|
The CI reports one failure on the branch for 3.9/uvloop, but the PR passed. Do they run the same tests? Was the one that failed just flaky? |
|
Thanks Byron! Yes there a couple of flaky tests under uvloop CI run... |
Signed-off-by: Waldemar Quevedo <wally@nats.io>
wallyqs
force-pushed
the
v2-token-count
branch
from
d287128 to
8858487
Compare
Signed-off-by: Waldemar Quevedo <wally@nats.io>
wallyqs
force-pushed
the
v2-token-count
branch
from
8858487 to
4aaaf0e
Compare
1 task
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See nats-io/nats-architecture-and-design#49