Skip to content

Fix websocket connection when not using TLS #463

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 21, 2023
Merged

Fix websocket connection when not using TLS #463

merged 1 commit into from
Jun 21, 2023

Conversation

wallyqs
Copy link
Member

@wallyqs wallyqs commented Jun 21, 2023

tls_required shown on INFO was making the a non TLS client try to upgrade even though it was not configured.

@wallyqs
Fix websocket connection when not using TLS
c2b5dcd 
Signed-off-by: Waldemar Quevedo <wally@nats.io>
@wallyqs wallyqs requested a review from bruth June 21, 2023 18:58
bruth
bruth approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@bruth bruth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Noting this is a workaround for the 2.9.19 server..

@wallyqs wallyqs merged commit 923361f into main Jun 21, 2023
@wallyqs wallyqs deleted the websocket-fix branch June 21, 2023 19:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@bruth bruth bruth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wallyqs @bruth