Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fixes memory leak in PushSubscription::unsubscribe #597

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

pySilver
Copy link
Contributor

@pySilver pySilver commented Aug 9, 2024

Fixes memory leak described in #596

Signed-off-by: Antoni Martyniuk

@pySilver pySilver changed the title Resolves #596 Fixes memory leak #596 Aug 9, 2024
@pySilver
Copy link
Contributor Author

pySilver commented Aug 9, 2024

Unfortunately, I have no idea how to reformat file. When running make format it does format way to much code outside of my changes.

Copy link
Collaborator

@caspervonb caspervonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I'll fix the formatting that's causing CI to fail.

@caspervonb caspervonb changed the title Fixes memory leak #596 Fixes memory leak in PushSubscribe::unsubscribe Aug 23, 2024
@caspervonb caspervonb changed the title Fixes memory leak in PushSubscribe::unsubscribe Fixes memory leak in PushSubscription::unsubscribe Aug 23, 2024
@caspervonb caspervonb merged commit 6ed9d26 into nats-io:main Aug 26, 2024
1 check passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants