Fix object store watch to use NEW rather than ALL #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caspervonb
force-pushed
the
fix-object-store-include-history
branch
from
57e8b06 to
0f4c4a9
Compare
caspervonb
force-pushed
the
fix-object-store-include-history
branch
from
0f4c4a9 to
1ee1883
Compare
|
Can you point to the similar code in nats.js? |
|
It's a breaking change, as it changes the behaviour. We might be better off with a new method with good name, and good docs? |
caspervonb
force-pushed
the
fix-object-store-include-history
branch
from
1ee1883 to
3edc9b8
Compare
@wallyqs see https://github.com/nats-io/nats.js/blob/747c3e58e65369bb7ad7dfd58d263f8335e465f8/obj/src/objectstore.ts#L838-L844
Possibly, or align with Go's other option. e.g include a kwarg for updates_only. |
|
I'll open another PR with |
aricart
approved these changes
Feb 18, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aligns with our behavior with nats.js, nats.go has some conflicting options regarding this behavior (https://github.com/nats-io/nats.go/blob/main/object.go#L1120-L1125)
Fixes #638