Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fixes for flywire_cave_query timestamp handling #159

Merged
merged 4 commits into from
May 29, 2022

Conversation

jefferis
Copy link
Collaborator

  • Was not possible to provide a timestamp
  • Also adds support for using expired materialisation versions (via their respective timestamps)

@codecov
Copy link

codecov bot commented May 29, 2022

Codecov Report

Merging #159 (5d39c5e) into master (d907d3b) will decrease coverage by 1.03%.
The diff coverage is 82.14%.

❗ Current head 5d39c5e differs from pull request most recent head 021c18b. Consider uploading reports for the commit 021c18b to get more accurate results

@@            Coverage Diff             @@
##           master     #159      +/-   ##
==========================================
- Coverage   45.42%   44.38%   -1.04%     
==========================================
  Files          32       32              
  Lines        3868     3893      +25     
==========================================
- Hits         1757     1728      -29     
- Misses       2111     2165      +54     
Impacted Files Coverage Δ
R/cave.R 60.16% <82.14%> (+10.16%) ⬆️
R/autosyn.R 36.59% <0.00%> (-9.39%) ⬇️
R/utils.R 47.90% <0.00%> (-1.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d907d3b...021c18b. Read the comment docs.

* because there's no potential for error, just some slowness
@jefferis jefferis merged commit 7121ed7 into master May 29, 2022
@jefferis jefferis deleted the fix/cave-query-timestamp branch May 29, 2022 20:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant