Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add xform.ngscene #168

Merged
merged 6 commits into from
Oct 8, 2022
Merged

add xform.ngscene #168

merged 6 commits into from
Oct 8, 2022

Conversation

jefferis
Copy link
Collaborator

@jefferis jefferis commented Oct 7, 2022

No description provided.

@codecov
Copy link

codecov bot commented Oct 7, 2022

Codecov Report

Merging #168 (88c9d0c) into master (f2cf567) will increase coverage by 0.49%.
The diff coverage is 84.21%.

@@            Coverage Diff             @@
##           master     #168      +/-   ##
==========================================
+ Coverage   51.04%   51.54%   +0.49%     
==========================================
  Files          33       34       +1     
  Lines        4114     4150      +36     
==========================================
+ Hits         2100     2139      +39     
+ Misses       2014     2011       -3     
Impacted Files Coverage Δ
R/meshparty-reticulate.R 0.00% <0.00%> (ø)
R/ng-scene.R 86.48% <86.48%> (ø)
R/flywire-coord.R 78.12% <0.00%> (-0.67%) ⬇️
R/urls.R 80.55% <0.00%> (+0.55%) ⬆️
R/flywire-urls.R 65.34% <0.00%> (+6.93%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

* not quite sure how, but had misunderstood the scaling operations
* just needs a regular homogenous 3x4 as input with translations in nm or
  whatever the natural units of the objects in the layer
* test this (validated the scene)
* also test for reglist
@jefferis jefferis marked this pull request as ready for review October 8, 2022 13:37
@jefferis jefferis merged commit ae195cc into master Oct 8, 2022
@jefferis jefferis deleted the feature/xform.ngscene branch October 8, 2022 13:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant