Fix/ngl annotation cols #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ensure col2hex has named return value * add tests
* was making a table and assuming that the colours and layers would always be on the diagonal but they don't have to be if the sort order is different * the test for correct behaviour is rather longer than the fix ...
* so we can use the subsetting operations elsewhere
* just so there's less noise during testing
* this is more flexible * with test
* this was a problem if we specific layers without colpal (which is a reasonable thing to do)
* with a warning
* it seems that this is necessary for annotation layers * it also seems to be the default for neuron layers * annotation layer colours were ignored when upper case
* with test
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #196 +/- ##
==========================================
+ Coverage 54.38% 56.59% +2.20%
==========================================
Files 38 38
Lines 4773 4787 +14
==========================================
+ Hits 2596 2709 +113
+ Misses 2177 2078 -99 ☔ View full report in Codecov by Sentry. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a selection of fixes / doc enhancement for annotation layers