Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(component): add once method #434

Merged
merged 2 commits into from
Jan 3, 2017
Merged

feat(component): add once method #434

merged 2 commits into from
Jan 3, 2017

Conversation

mixed
Copy link
Member

@mixed mixed commented Dec 28, 2016

Issue

Ref #412

Details

once is executed event just one time.

Preferred reviewers

@happyhj @jongmoon

Copy link
Contributor

@sculove sculove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jongmoon jongmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mixed But I have a question~! Don't we have to comply coding convention?

@mixed
Copy link
Member Author

mixed commented Jan 3, 2017

@jongmoon
Yes. We have to comply coding convetion. You have a feeling my code is wrong?

@jongmoon
Copy link
Contributor

jongmoon commented Jan 3, 2017

@mixed As below.

https://github.com/naver/egjs/pull/434/files#diff-36f2c7f7bbf377bdc2b3eacfa9332396R431

  ok( callCount, 1); //TOBE: ok(callCount, 1);

https://github.com/naver/egjs/pull/434/files#diff-36f2c7f7bbf377bdc2b3eacfa9332396R390

test("once method should be fire event one time.",function(){ // space is need before function()

@mixed
Copy link
Member Author

mixed commented Jan 3, 2017

@jongmoon
Ah.... Thanks. I agree with you but currently Coding covention applied only source code. What do you think discuss this issue at next offline meeting?

@jongmoon
Copy link
Contributor

jongmoon commented Jan 3, 2017

@mixed no problem!

I think there would be many uncomplied source code.

@mixed mixed merged commit 62f456e into naver:master Jan 3, 2017
@mixed mixed deleted the once branch January 3, 2017 06:42
malangfox pushed a commit that referenced this pull request Jan 6, 2025
once is executed event just one time.

Ref #412
Close #412
malangfox pushed a commit that referenced this pull request Jan 7, 2025
once is executed event just one time.

Ref #412
Close #412
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants