-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat(component): add once method #434
Conversation
once is executed event just one time. Ref naver#412
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@mixed But I have a question~! Don't we have to comply coding convention?
@jongmoon |
@mixed As below. https://github.com/naver/egjs/pull/434/files#diff-36f2c7f7bbf377bdc2b3eacfa9332396R431 ok( callCount, 1); //TOBE: ok(callCount, 1); https://github.com/naver/egjs/pull/434/files#diff-36f2c7f7bbf377bdc2b3eacfa9332396R390 test("once method should be fire event one time.",function(){ // space is need before function() |
@jongmoon |
@mixed no problem! I think there would be many uncomplied source code. |
Issue
Ref #412
Details
once is executed event just one time.
Preferred reviewers
@happyhj @jongmoon