Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(flicking): Fix wrong referencing of panel elements #457

Merged
merged 2 commits into from
Mar 3, 2017
Merged

fix(flicking): Fix wrong referencing of panel elements #457

merged 2 commits into from
Mar 3, 2017

Conversation

netil
Copy link
Member

@netil netil commented Feb 20, 2017

Issue

#438

Details

When container element is given,
corrected referencing panel elements properly.

Preferred reviewers

@sculove

netil added 2 commits February 20, 2017 19:38
@netil
fix(flicking): Fix wrong referencing of panel elements
a339848 
When container element is given,
corrected referencing panel elements properly.

Ref naver#438
@netil
skip: changes finding container element
b1a4c53
@netil netil added this to the 1.5.0 milestone Feb 20, 2017
@netil netil self-assigned this Feb 20, 2017
@netil netil requested a review from sculove February 20, 2017 10:54
sculove
sculove reviewed Feb 23, 2017
View reviewed changes
Copy link
Contributor

@sculove sculove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sculove
sculove approved these changes Feb 23, 2017
View reviewed changes
Copy link
Contributor

@sculove sculove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@netil netil merged commit db6945a into naver:master Mar 3, 2017
malangfox pushed a commit that referenced this pull request Jan 6, 2025
@netil
fix(flicking): Fix wrong referencing of panel elements
30ee747 
When container element is given,
corrected referencing panel elements properly.

Fix #438
Close #457
malangfox pushed a commit that referenced this pull request Jan 7, 2025
@netil
fix(flicking): Fix wrong referencing of panel elements
e51abe0 
When container element is given,
corrected referencing panel elements properly.

Fix #438
Close #457
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@sculove sculove sculove approved these changes

Assignees

@netil netil

Labels
bug flicking
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@netil @sculove