Removing "format" action from non-autocorrectable rules

Per some discussion in #8
nbadal · Oct 20, 2020 · 7ccdb3f · 7ccdb3f
1 parent 7b93f7c
commit 7ccdb3f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,7 @@
 - Add post-format linter, with ability to disable via setting
 
 ### Changed
+- Format action no longer appears for non-autocorrectable rules, since it doesn't address them.
 
 ### Deprecated
 

diff --git a/src/main/kotlin/com/nbadal/ktlint/KtlintAnnotator.kt b/src/main/kotlin/com/nbadal/ktlint/KtlintAnnotator.kt
@@ -28,7 +28,7 @@ class KtlintAnnotator : ExternalAnnotator<PsiFile, List<LintError>>() {
             val severity = if (config.treatAsErrors) HighlightSeverity.ERROR else HighlightSeverity.WARNING
 
             holder.createAnnotation(severity, errorRange, message).apply {
-                registerFix(KtlintFormatAction())
+                if (it.canBeAutoCorrected) registerFix(KtlintFormatAction())
                 registerFix(KtlintGlobalDisableRuleAction(it.ruleId))
                 registerFix(KtlintDisableAction())
             }