Add support for async middleware #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CircleCI configuration has changed and the old config did not work anymore.
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for async middleware.
Most functionality was pretty straight forward to implement with async middleware - I just took out the functionality from e.g.
wrap-log-request-paramsinto a private function, which is called from the sync and the async middleware function.The response middleware was a bit more difficult. I couldn't think of a good way to prevent the repetition of
base-message,start-msetc.The async tests are a direct copy of the sync tests, they just use the async middleware, obviously.
Unfortunately one of the
tools-logging-tests will fail when both of them are enabled, and I couldn't understand why that happens. They both pass when I run only the single namespace's tests. I disabled the async version of the tools-logging-test for now. I'm not sure if it's such an important test in the end?Closes #46