Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add ansible_group resource #8

Merged
merged 1 commit into from
Feb 25, 2018
Merged

Conversation

jtopjian
Copy link
Contributor

For #3

Hi @nbering!

Around a month ago I created https://github.com/jtopjian/terraform-provider-ansible-inventory. My original name for the provider was terraform-provider-ansibleinventory. I felt that was clunky and wanted to change it to terraform-provider-ansible. That's when I came across your project 😄

Our work is practically identical, so I'm happy to defer to your project since it was around first (IMO, the problem being solved here is too niche to have more than one solution).

I modified my original ansible_group resource to fit the style laid out in your ansible_host resource. Let me know if you have any questions or would like anything changed.

I also have an Ansible inventory script written in Go here. I will break that out into its own repository and modify it to be compatible with this repo.

@nbering
Copy link
Owner

nbering commented Feb 25, 2018

Wow, that's awesome! Thanks!

@nbering
Copy link
Owner

nbering commented Feb 25, 2018

I opted to build the Inventory Script in Python to match the idiomatic language of Ansible (not that I write idiomatic Python). My intent was to make a version that takes advantage of the new Inventory Plugin API in Ansible 2.4... whenever I get around to it.

My original implementation of the inventory script was in TypeScript, just because JSON is easy to manipulate in a JS environment, and I built out type structures to represent the Ansible state format and it made it easier to avoid writing bugs when working with dynamic structures. My Python version is a direct port from my TypeScript code.

@jtopjian
Copy link
Contributor Author

I have no strong opinion about the choice of language for the dynamic inventory script. I wrote my inventory script in Go because that's what I'm more familiar with. IMO, having a single solution for the inventory side of things is less important than the Terraform side.

I mentioned I would break out my inventory script into its own repo, but that in no way means I want to battle for the official inventory script 😄

My intent was to make a version that takes advantage of the new Inventory Plugin API in Ansible 2.4

ah - I didn't know there was an API. I agree that this would be beneficial.

Thanks for the merge!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants