Fix win32 build #70
Merged
Fix win32 build #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was just considering doing the same fix to support arm 32bits target. Hope this PR will be accepted! |
nbigaouette
reviewed
Apr 9, 2021
| - target: x86_64-pc-windows-msvc | ||
| os: windows-latest | ||
| - target: i686-pc-windows-msvc | ||
| os: windows-latest |
There was a problem hiding this comment.
Why was the target and os inverted in the matrix?
There was a problem hiding this comment.
If we don't invert this, only 3 jobs for each os will be executed ;(
nbigaouette
added a commit
that referenced
this pull request
Apr 11, 2021
nbigaouette
added a commit
that referenced
this pull request
Apr 11, 2021
|
Sorry for late, you merged this! |
|
Yeah I had a couple of cycles today so went on and merge this. Thanks for the clarifications, and the contribution! Version 0.0.12 is released with this. |
tc-wolf
added a commit
to tc-wolf/onnxruntime-rs
that referenced
this pull request
May 12, 2021
* Update bindgen config to use `usize` * Update macOS bindings * Update Linux bindings * Update Windows (x86_64) bindings * Update Windows (x86) bindings * Use `usize` instead of `u64` * Use conditional function calling conventions * Re-enable CI for Windows 32bit * Fix CI matrix * Add generated bindings for Apple M1 * On macOS Big Sur, homebrew installs to /opt/homebrew instead of /usr/local, adapt installation notes * Feature is 'generate-bindings', not 'bindgen'. Change error message * Add more paths to include directory, required when compilling and installing from source * Formatting * Compilation notes: environment variable was changed to 'ORT_LIB_LOCATION' (from 'ONNXRUNTIME_INSTALL_DIR') * Add entry to changelog * Add macOS aarch64 to README * Add note about LD_LIBRARY_PATH in README * Add a VSCode config to run clippy and format on save * Clippy: Allow upper case acronyms, names coming from specific ML models * Fix clippy lint: Change 'Into' impls to 'From' * Add ORT_LIB_LOCATION note in readme for 'ORT_STRATEGY=system' * Update changelog following nbigaouette#70 * Update macos/aarch64 bindings following nbigaouette#70 * Formatting * Upgrade 'ndarray' to 0.15 (from 0.13) * Upgrade 'ureq' to 2.1 (from 1.5) * Add changelog entries * Clippy: Box the larse ureq::Error in OrtDownloadError * Release v0.0.12 * Return an Err on shape mismatch instead of panic This way we let the user of the library decide how to handle the issue. Co-authored-by: krazijames <krazijames@gmail.com> Co-authored-by: Nicolas Bigaouette <nbigaouette@gmail.com> Co-authored-by: Keith Lohnes <lohnesk@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, I had to use
onnxruntimecrate on Windows 32bit but it doesn't seem to work because there are some mismatched types & function calling conventions betweenonnxruntime-sysandonnxruntime. So I fixed the binding generation config to useusizeinstead ofu64, and added macros for choosing appropriate function calling conventions according to the target architecture, and also re-enabled CI fori686.