Disable CheckInlineValueIsComplete for Fable #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alfonsogarciacaro Sure, whatever works. It's nice that you found a work-around. |
|
@ncave Would it be possible to merge this? Unfortunately one of my projects depend on this and I'm afraid the change my be lost when we resync |
|
Thank you! |
|
@alfonsogarciacaro Sure thing, Alfonso, for you - anytime :) |
ncave
pushed a commit
that referenced
this pull request
Jul 3, 2022
ncave
pushed a commit
that referenced
this pull request
Aug 26, 2022
ncave
pushed a commit
that referenced
this pull request
Nov 14, 2022
ncave
pushed a commit
that referenced
this pull request
Nov 30, 2022
ncave
pushed a commit
that referenced
this pull request
Feb 24, 2023
ncave
pushed a commit
that referenced
this pull request
Apr 15, 2023
ncave
pushed a commit
that referenced
this pull request
Oct 23, 2023
ncave
pushed a commit
that referenced
this pull request
Dec 8, 2023
ncave
pushed a commit
that referenced
this pull request
Nov 16, 2024
ncave
pushed a commit
that referenced
this pull request
Jan 15, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not entirely sure about this so I'm opening the PR for discussion. It happens that many Fable-compatible libraries include code under
FABLE_COMPILERthat inline functions accessing internal values in order to resolve generics. This code gives no errors when compiling everything as a single project as Fable normally does, but id does fail when generating a .dll assembly. I've noticed that by disabling theCheckInlineValueIsCompletein Optimizer.fs the error disappears. So I thought we could remove it when compiling FCS for Fable. I choseFABLE_CLIbecause this is not meant to be compiled to JS.What do you think @ncave?