Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Refactor: Migrate to Minitest 5 and ActiveSupport 5 #165

Merged
merged 4 commits into from
Sep 28, 2024

Conversation

alexskr
Copy link
Member

@alexskr alexskr commented Sep 27, 2024

Minitest 5 update, supersedes #143

  • update minitest to v5
  • fix for invalid unit tests that didn't manifest unitl this update TestNotesController#test_proposal_lifecycle = DEPRECATED: Use assert_nil if expecting nil from /srv/ontoportal/ontologies_api/test/controllers/test_notes_controller.rb:111. This will fail in Minitest 6.
  • minor minitest style updates

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.39%. Comparing base (15a5d03) to head (e8301e6).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #165   +/-   ##
========================================
  Coverage    73.39%   73.39%           
========================================
  Files           53       53           
  Lines         2954     2954           
========================================
  Hits          2168     2168           
  Misses         786      786           
Flag Coverage Δ
unittests 73.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexskr alexskr changed the title Ontoportal lirmm pr/refactor/migrate to minitest 5 Refactor: Migrate to Minitest 5 and ActiveSupport 5 Sep 28, 2024
@alexskr alexskr marked this pull request as ready for review September 28, 2024 00:18
@alexskr
Copy link
Member Author

alexskr commented Sep 28, 2024

TestRecommenderV1Controller unit test has intermittent failures under AllegroGraph

1) Failure:
TestRecommenderV1Controller#test_recommend_query [test/controllers/test_recommender_v1_controller.rb:27]:
Failed to return 3 recommendations.
Expected: 3
  Actual: 0

recommender_v1 is not used and should be deprecated. I don't think its worth troubleshooting this failing test

@alexskr alexskr merged commit c2f1c58 into develop Sep 28, 2024
2 of 4 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants