Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fixes for fetchSCAN() #210

Merged
merged 4 commits into from
Oct 12, 2021
Merged

Fixes for fetchSCAN() #210

merged 4 commits into from
Oct 12, 2021

Conversation

brownag
Copy link
Member

@brownag brownag commented Oct 12, 2021

dylanbeaudette
dylanbeaudette reviewed Oct 12, 2021
View reviewed changes
R/fetchSCAN.R
@@ -187,16 +189,20 @@ fetchSCAN <- function(site.code, year, report='SCAN', req=NULL) {
# save: sensor suite -> site number -> year
sensors <- c('SMS', 'STO', 'SAL', 'TAVG', 'TMIN', 'TMAX', 'PRCP', 'PREC', 'SNWD', 'WTEQ', 'WDIRV', 'WSPDV', 'LRADT')
for(sensor.i in sensors) {
d.list[[sensor.i]][[as.character(i$sitenum)]][[as.character(i$year)]] <- .formatSCAN_soil_sensor_suites(d, code=sensor.i)
site.i <- as.character(i$sitenum)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much cleaner, thanks.

@dylanbeaudette
Copy link
Member

Thanks for fixing / updating this code.

@brownag brownag merged commit 2380831 into master Oct 12, 2021
@brownag brownag deleted the fix-fetchSCAN branch October 13, 2021 03:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@dylanbeaudette dylanbeaudette dylanbeaudette left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brownag @dylanbeaudette