Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: extract endpoint variables into separate constants file #9

Merged
merged 2 commits into from
Oct 11, 2020

Conversation

kvithana
Copy link
Contributor

@kvithana kvithana commented Oct 9, 2020

Small change to extract the endpoint strings out to a constants file since there was already some reuse happening in the Tags API. Moved the base URL into the constants as well as it will be used in the pagination #5 util function.

Copy link
Owner

@ndench ndench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @kvithana.

@ndench ndench merged commit 0f25871 into ndench:master Oct 11, 2020
@kvithana
Copy link
Contributor Author

have finished the pagination stuff will make the PR later today!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants