Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: main useMemo, add dependency on currentDatetime #124

Merged
merged 1 commit into from
May 16, 2024

Conversation

weissleb
Copy link
Contributor

@weissleb weissleb commented May 3, 2024

Description

My use case, which feels pretty common, has me wanting the timezone options to update when the currentDatetime changes. So if we include a date picker in our app and the user chooses a date in which the timezones switch from standard to daylight, the options in the select update automatically.

Linked Issues

More detail, and an updated example can be found in this forked branch. I also opened an enhancement issue.

Additional context

If there's a preferred way of accomplishing my goal without this change, I'm all ears!

Fixes: #123

@weissleb
Copy link
Contributor Author

@ndom91 just nudging here. It looks like you're still maintaining this package. I realize you may be quite busy, but hoping it is reasonable to get this merged, or commented on, so we can start using this in production without our fork. Very much appreciated.

@ndom91
Copy link
Owner

ndom91 commented May 16, 2024

Hey thanks for the reminder 😅 . This looks like a sane, small, change.

Thanks!

@ndom91 ndom91 changed the title Depend on currentDatetime. fix: main useEffect, add dependency on currentDatetime May 16, 2024
@ndom91 ndom91 changed the title fix: main useEffect, add dependency on currentDatetime fix: main useMemo, add dependency on currentDatetime May 16, 2024
@ndom91 ndom91 merged commit 3f075e1 into ndom91:main May 16, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update TimezoneSelectOptions on currentDatetime Change
2 participants