chore: remove Cargo.lock

[joshuajbouw]

The Cargo.lock was left in for the library. This is wrong and should be removed as you may run into confusing situations as #63 highlights. Typically, it is only acceptable to have a Cargo.lock file for binaries when you need the compiled code to be exactly the same on everyone's machines. For libraries, this simply isn't required and highly not recommended.

A bit more reading, a Cargo.locks point is to lock the version state of all dependencies to ensure that the builds across all devices is the same with no surprises as of course, who knows what may pop up in a new patch of a dependency. Leaving it in for a library the dependencies will be checked by binaries / other libraries that use the library and will result in dependency clashes.

Rule of thumb: If its a binary as it is the end of a dependency chain, keep the Cargo.lock file. If it is a library, do not include it.

This will not automatically solve the problem if you already have a Cargo.lock, you MUST run cargo update to fix this post this PR. It will prevent others from getting into trouble with it though.

Reference: https://doc.rust-lang.org/cargo/faq.html#why-do-binaries-have-cargolock-in-version-control-but-not-libraries

[artob]

@ilblackdragon Any objection to merging this?

[artob]

@joshuajbouw In the future, please ensure all text files are terminated by a newline.

[ilblackdragon]

So there is an important part: - even though the smart contract is compiled as a library, it is actually a binary that must be reproducible - without Cargo.lock this means that no one ever will be able to reproduce the compiled WASM binary and match that indeed this binary is matching this source code.

…

On Fri, Mar 5, 2021 at 5:45 AM Arto Bendiken ***@***.***> wrote: Merged #65 <#65> into master. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#65 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABK27RPOBNFJFXAKBGMISDTCDOBNANCNFSM4YCHIFEQ> .

-- Best regards, Illia Polosukhin

[joshuajbouw]

You are correct, now that I'm aware of how we are using WASM as it is indeed compiled. This is important.