-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix contract call fee issue #3158
Comments
Please advise if this affects if/how we should communicate to launch partners when you have a free moment. |
Please comment on near/NEPs#97 (comment) |
Consider testing the rewrite of wasmer (wasmer-reborn): https://github.com/wasmerio/wasmer-reborn |
@frol looks like the repo doesn't exist |
It seems they had made it private again... Should we ask them to share it with us? 😃 |
It seems risky to try a new VM that is less tested. We could revisit when it's stabilized. |
@frol looks like it's already merged wasmerio/wasmer@518e0f3 |
Setting estimate to 5 -- how much time it is going to take in this cycle. |
Move `RuntimeConfig` from `Runtime` initialization to `ApplyState` object. This makes `Runtime` completely stateless and allows to execute transitions based on different configs. It allows to upgrade `RuntimeConfig` with the new fees based on the protocol version for the current block. This change should be NOOP and doesn't change the protocol. NEP: near/NEPs#120 Issue: #3158 # Test plan: - [X] CI - [x] http://nayduck.eastus.cloudapp.azure.com:3000/#/run/553
Move `RuntimeConfig` from `Runtime` initialization to `ApplyState` object. This makes `Runtime` completely stateless and allows to execute transitions based on different configs. It allows to upgrade `RuntimeConfig` with the new fees based on the protocol version for the current block. This change should be NOOP and doesn't change the protocol. NEP: near/NEPs#120 Issue: #3158 # Test plan: - [X] CI - [x] http://nayduck.eastus.cloudapp.azure.com:3000/#/run/553
Move `RuntimeConfig` from `Runtime` initialization to `ApplyState` object. This makes `Runtime` completely stateless and allows to execute transitions based on different configs. It allows to upgrade `RuntimeConfig` with the new fees based on the protocol version for the current block. This change should be NOOP and doesn't change the protocol. NEP: near/NEPs#120 Issue: #3158 # Test plan: - [X] CI - [x] http://nayduck.eastus.cloudapp.azure.com:3000/#/run/553
Move `RuntimeConfig` from `Runtime` initialization to `ApplyState` object. This makes `Runtime` completely stateless and allows to execute transitions based on different configs. It allows to upgrade `RuntimeConfig` with the new fees based on the protocol version for the current block. This change should be NOOP and doesn't change the protocol. NEP: near/NEPs#120 Issue: #3158 # Test plan: - [X] CI - [x] http://nayduck.eastus.cloudapp.azure.com:3000/#/run/553
This issue has been automatically marked as stale because it has not had recent activity in the last 2 months. |
Superseded by #4401 |
We have discovered that we were under# contract call fee due to a bug in param estimator tool that was hidden by a bug introduced in this PR: https://github.com/nearprotocol/nearcore/pull/2845/files#diff-a811f7fb6a4892a2b6cc0098f7f68616R567. It turns out 300KiB contracts would cost >100Tgas to compile which is prohibitively expensive for our partners. According to @willemneal this is not only a Wasmer issue, but Wasmtime+lightbeam have the same CPU cost.
We need to fix it urgently and delay Mainnet launch until we do so CC @SkidanovAlex , @bowenwang1996 Things that we need to do:
The text was updated successfully, but these errors were encountered: