do not merge: cache for storing vm artifacts #10787
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 20, 2024
`AnyCache` is a part of the now-expanded concept of the `ContractRuntimeCache`. It allows runtimes to put anything they would like into it, so long as this cache is keyed by `CryptoKey`. Initially I was in a lot of pain as intermediate drafts have required me to add a `unsafe impl Sync for UniversalArtifact` which I'm not sure I could possibly prove. However in the end I ended up being able to avoid it entirely by giving out `AnyCache` by reference only. Lovely! -- EDIT: crappa, looks like I did something wrong testing this locally T_T Sync appears to remain a requirement. Note that only NearVM uses this cache currently. I don't see a good reason to port this code back to the old runtimes. Supersedes #10787 Co-authored-by: Longarithm <the.aleksandr.logunov@gmail.com>
nagisa
added a commit
to nagisa/nearcore
that referenced
this pull request
Mar 20, 2024
`AnyCache` is a part of the now-expanded concept of the `ContractRuntimeCache`. It allows runtimes to put anything they would like into it, so long as this cache is keyed by `CryptoKey`. Initially I was in a lot of pain as intermediate drafts have required me to add a `unsafe impl Sync for UniversalArtifact` which I'm not sure I could possibly prove. However in the end I ended up being able to avoid it entirely by giving out `AnyCache` by reference only. Lovely! -- EDIT: crappa, looks like I did something wrong testing this locally T_T Sync appears to remain a requirement. Note that only NearVM uses this cache currently. I don't see a good reason to port this code back to the old runtimes. Supersedes near#10787 Co-authored-by: Longarithm <the.aleksandr.logunov@gmail.com>
|
We have AnyCache now. Thank you. |
VanBarbascu
pushed a commit
that referenced
this pull request
Mar 26, 2024
`AnyCache` is a part of the now-expanded concept of the `ContractRuntimeCache`. It allows runtimes to put anything they would like into it, so long as this cache is keyed by `CryptoKey`. Initially I was in a lot of pain as intermediate drafts have required me to add a `unsafe impl Sync for UniversalArtifact` which I'm not sure I could possibly prove. However in the end I ended up being able to avoid it entirely by giving out `AnyCache` by reference only. Lovely! -- EDIT: crappa, looks like I did something wrong testing this locally T_T Sync appears to remain a requirement. Note that only NearVM uses this cache currently. I don't see a good reason to port this code back to the old runtimes. Supersedes #10787 Co-authored-by: Longarithm <the.aleksandr.logunov@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.