rust: 1.85.0 / edition 2024

[nagisa]

Formatting style changed so the reviewability of this is non-existent. The first two commits should be roughly reviewable though. Most of the changes are trivial adaptations for edition 2024:

• gen became a reserved keyword, mitigated by using a raw identifier r#gen;
• unsafe_on_in_unsafe_fn became a warning by default which for us is a compilation failure, mitigated by wrapping unsafe operations individually in unsafe {} (I spent some time to update safety docs at the same time);
• RPIT lifetime capture rules changed, which broke code in a few places and required use<> annotations;
• match ergonomics reservations got triggered a significant number of times which required removing ref in most places;
• A couple instances of ! type fallback changes made type resolution break and required manual annotations;
• We triggered newly reserved syntax in our macro use, which I replaced with something else.

[codecov]

Codecov Report

Attention: Patch coverage is 56.39344% with 266 lines in your changes missing coverage. Please review.

Project coverage is 70.22%. Comparing base (c6ee928) to head (c999891).
Report is 6 commits behind head on master.

Files with missing lines	Patch %	Lines
core/primitives/src/errors.rs	0.00%	94 Missing ⚠️
...hain/src/stateless_validation/chunk_endorsement.rs	11.11%	24 Missing ⚠️
chain/chain/src/runtime/tests.rs	58.33%	10 Missing ⚠️
chain/chunks/src/shards_manager_actor.rs	74.35%	6 Missing and 4 partials ⚠️
chain/rosetta-rpc/src/adapters/mod.rs	86.20%	8 Missing ⚠️
core/primitives/src/receipt.rs	0.00%	8 Missing ⚠️
chain/client/src/client_actor.rs	12.50%	6 Missing and 1 partial ⚠️
chain/network/src/config.rs	36.36%	7 Missing ⚠️
chain/chain/src/store_validator/validate.rs	0.00%	6 Missing ⚠️
core/chain-configs/src/genesis_validate.rs	44.44%	5 Missing ⚠️
... and 48 more

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #12966      +/-   ##
==========================================
- Coverage   70.24%   70.22%   -0.02%     
==========================================
  Files         855      855              
  Lines      176287   176569     +282     
  Branches   176287   176569     +282     
==========================================
+ Hits       123837   124003     +166     
- Misses      47296    47406     +110     
- Partials     5154     5160       +6     

Flag	Coverage Δ
backward-compatibility	0.35% <0.00%> (-0.01%)	⬇️
db-migration	0.35% <0.00%> (-0.01%)	⬇️
genesis-check	1.41% <0.00%> (-0.01%)	⬇️
linux	69.80% <56.39%> (-0.07%)	⬇️
linux-nightly	69.86% <56.39%> (-0.04%)	⬇️
pytests	1.71% <0.00%> (-0.01%)	⬇️
sanity-checks	1.52% <0.00%> (-0.01%)	⬇️
unittests	70.06% <56.39%> (-0.03%)	⬇️
upgradability	0.35% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[shreyan-gupta]

There were too many files to take a detailed look at, so just approving to unblock!

[shreyan-gupta]

It would have been really nice to have the cargo fmt related changes as part of a separate PR from the update :(

That was possible according to this doc

[nagisa]

Doesn't splitting up the formatting into its own commit within PR achieve the very same thing? (Admittedly our PR merges squash, but for the purposes of review there isn't a meaningful difference, is there?)