use tracing instead of log #12973
Open
use tracing instead of log #12973
+98
−78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Levi0804
force-pushed
the
use-tracing
branch
from
f325010 to
65c9af1
Compare
nagisa
reviewed
Feb 21, 2025
| @@ -27,7 +27,6 @@ enum Commands { | |||
|
|
|||
| #[tokio::main] | |||
| async fn main() -> anyhow::Result<()> { | |||
| env_logger::init(); | |||
There was a problem hiding this comment.
Isn't it necessary to initialize a tracing logger here?
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #12911. Please let me know if these changes look good.