feat(build) Added set -eux to all steps of the CI pipeline #4589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhalambek
approved these changes
Jul 28, 2021
|
that's not pre-commit hook, right? That is ,there's typo in the title? |
|
Wow, good catch. I don't know how did I came up with the precommand name (wuuuut)😄 Changed. |
|
Oh, no it is actually |
chefsale
force-pushed
the
precommit
branch
2 times, most recently
from
5a2e986 to
ee1072d
Compare
chefsale
changed the title
matklad
approved these changes
Jul 28, 2021
|
It doesn't seem to work, as it runs in a seperate shell and has no affect on other steps. It seems like we will need to run this in every step. I will update the PR. |
chefsale
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The approach of the pre-command hook doesn't work: #4589 (comment)