Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

re: Fix clippy::redundant_closure' #5947

Merged
merged 1 commit into from
Dec 22, 2021
Merged

re: Fix clippy::redundant_closure' #5947

merged 1 commit into from
Dec 22, 2021

Conversation

pmnoxx
Copy link
Contributor

@pmnoxx pmnoxx commented Dec 22, 2021

Fix clippy::redundant_closure' issue

@pmnoxx
Copy link
Contributor Author

pmnoxx commented Dec 22, 2021 

@bowenwang1996 @mm-near: /chain/ /core/ /neard/ /runtime/
@nikurt: /genesis-tools/ /test-utils/state-viewer
@matklad @posvyatokum: /test-utils/runtime-tester
@chefsale @khorolets: /chain/client/src/view_client.rs

@bowenwang1996 @chefsale @khorolets @matklad @mm-near @nikurt @posvyatokum Can you take a look?

matklad
matklad approved these changes Dec 22, 2021
View reviewed changes
Copy link
Contributor

@matklad matklad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but many cases can be further simplified to .unwrap_or_default()

chain/chain/src/store.rs Outdated Show resolved Hide resolved
@pmnoxx pmnoxx self-assigned this Dec 22, 2021
@near-bulldozer near-bulldozer bot merged commit 5a7f933 into master Dec 22, 2021
@near-bulldozer near-bulldozer bot deleted the piotr-redundant_closure branch December 22, 2021 10:20
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@matklad matklad matklad approved these changes

@bowenwang1996 bowenwang1996 Awaiting requested review from bowenwang1996

@chefsale chefsale Awaiting requested review from chefsale

@EgorKulikov EgorKulikov Awaiting requested review from EgorKulikov

@khorolets khorolets Awaiting requested review from khorolets

@mm-near mm-near Awaiting requested review from mm-near

@mzhangmzz mzhangmzz Awaiting requested review from mzhangmzz

@nikurt nikurt Awaiting requested review from nikurt

@posvyatokum posvyatokum Awaiting requested review from posvyatokum

Assignees

@pmnoxx pmnoxx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pmnoxx @matklad