network: remove near_<msg-type>_{total,bytes} metrics #6661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove near_<msg-type>_total metrics. Data in those metrics are
available in a near_peer_message_received_by_type_total{type} metric
which is easier to deal with since it’s a single metric with a label
for all types rather than multiple metrics.
Similarly, replace near_<msg-type>_bytes metrics with a new
near_peer_message_received_by_type_bytes metric.
The near_<msg-type>_dropped metric is left as is for now but will be
dealt with in another change.
nikurt
approved these changes
Apr 21, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
near_<msg-type>_totalmetrics. Data in those metrics areavailable in a
near_peer_message_received_by_type_totalmetric witha
typelabel which is easier to deal with.Similarly,
replace near_<msg-type>_bytesmetrics with a single newnear_peer_message_received_by_type_bytesmetric usingtypelabel.The
near_<msg-type>_droppedmetric is left as is for now but will bedealt with in another change.