runtime: add near_action_called_count metric with an action label
#6679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace `near_action_<action-type>_total` metrics with a single `near_action_called_count` metric with an action label. This simplifies the code considerably and makes it easier to scrape, aggregate and otherwise manipulate the metric in Prometheus.
mzhangmzz
approved these changes
Apr 26, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
near_action_<action-type>_totalmetrics with a singlenear_action_called_countmetric with an action label. Thissimplifies the code considerably and makes it easier to scrape,
aggregate and otherwise manipulate the metric in Prometheus.