feat: Disable state sync by default because it's unreliable #8730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 14, 2023 12:29
nikurt
changed the title
akhi3030
approved these changes
Mar 21, 2023
posvyatokum
pushed a commit
that referenced
this pull request
Mar 26, 2023
Add a config option `state_sync_enabled`. Default value is `false`. If the option is `true`, state sync works as usual, but prints this message every 10 seconds: ``` Mar 15 07:31:11 nikurt-4 neard[48582]: 2023-03-15T07:31:11.352458Z WARN stats: The node is syncing its State. The current implementation of this mechanism is known to be unreliable. It may never complete, or fail randomly and corrupt the DB. Mar 15 07:31:11 nikurt-4 neard[48582]: Suggestions: Mar 15 07:31:11 nikurt-4 neard[48582]: * Download a recent data snapshot and restart the node. Mar 15 07:31:11 nikurt-4 neard[48582]: * Disable state sync in the config. Add `"state_sync_enabled": false` to `config.json`. Mar 15 07:31:11 nikurt-4 neard[48582]: A better implementation of State Sync is work in progress. ``` If the option is `false`, the node proceeds to download and apply blocks. Started a node from a month-old snapshot. After about 24 hours of running I see this, which confirms that the Block Sync is enabled and State Sync wasn't enabled: ``` Mar 15 07:32:27 nikurt-3 neard[36289]: 2023-03-15T07:32:27.565700Z INFO stats: #118440788 Downloading blocks 4.70% (1951625 left; at 118440788) 23 peers ⬇ 638 kB/s ⬆ 86.9 kB/s 2.00 bps 70.7 Tgas/s CPU: 62%, Mem: 4.27 GB ``` Fix #8719
nikurt
added a commit
that referenced
this pull request
Apr 14, 2023
Add a config option `state_sync_enabled`. Default value is `false`. If the option is `true`, state sync works as usual, but prints this message every 10 seconds: ``` Mar 15 07:31:11 nikurt-4 neard[48582]: 2023-03-15T07:31:11.352458Z WARN stats: The node is syncing its State. The current implementation of this mechanism is known to be unreliable. It may never complete, or fail randomly and corrupt the DB. Mar 15 07:31:11 nikurt-4 neard[48582]: Suggestions: Mar 15 07:31:11 nikurt-4 neard[48582]: * Download a recent data snapshot and restart the node. Mar 15 07:31:11 nikurt-4 neard[48582]: * Disable state sync in the config. Add `"state_sync_enabled": false` to `config.json`. Mar 15 07:31:11 nikurt-4 neard[48582]: A better implementation of State Sync is work in progress. ``` If the option is `false`, the node proceeds to download and apply blocks. Started a node from a month-old snapshot. After about 24 hours of running I see this, which confirms that the Block Sync is enabled and State Sync wasn't enabled: ``` Mar 15 07:32:27 nikurt-3 neard[36289]: 2023-03-15T07:32:27.565700Z INFO stats: #118440788 Downloading blocks 4.70% (1951625 left; at 118440788) 23 peers ⬇ 638 kB/s ⬆ 86.9 kB/s 2.00 bps 70.7 Tgas/s CPU: 62%, Mem: 4.27 GB ``` Fix #8719
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a config option
state_sync_enabled. Default value isfalse.If the option is
true, state sync works as usual, but prints this message every 10 seconds:If the option is
false, the node proceeds to download and apply blocks.Started a node from a month-old snapshot. After about 24 hours of running I see this, which confirms that the Block Sync is enabled and State Sync wasn't enabled:
Fix #8719