Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: cleanup & simplify environment variables #55

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

shelegdmitriy
Copy link
Contributor

@shelegdmitriy shelegdmitriy commented Jul 22, 2024

Related to near/near-discovery#1194

NOTE: this PR makes braking changes and requires updating the existing .env.local file and Vercel environment variables

@shelegdmitriy shelegdmitriy self-assigned this Jul 22, 2024
Copy link

vercel bot commented Jul 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pagoda-experiments-ticketing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2024 3:54pm

@shelegdmitriy
Copy link
Contributor Author

@calebjacob @jackson-harris-iii @charleslavon I believe this scope of work in this PR is enough for the first round of cleanup, WDYT? I seems we'll need to split such cleanups into a few PRs more to make sure we tested everything propertly

Copy link
Collaborator

@calebjacob calebjacob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks @shelegdmitriy. I did a double check on the ENV variables we moved over and they're all safe to be public. 👍

@shelegdmitriy shelegdmitriy force-pushed the chore/simplify-env-variables branch from 7df4c90 to b1d6534 Compare July 24, 2024 15:50
@shelegdmitriy shelegdmitriy merged commit 66c58ee into main Jul 24, 2024
2 checks passed
@shelegdmitriy shelegdmitriy deleted the chore/simplify-env-variables branch July 24, 2024 15:59
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants