Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Implement TurboModuleRegistry #2503

Closed
wants to merge 1 commit into from
Closed

Conversation

johnf
Copy link

@johnf johnf commented Mar 27, 2023

This is a super naive implementation. I don't have any native experience.

I based this on the react-native implementation, which falls back to native based on the bridge type.
I remove all the checking code and always fall back to nativemodules.

From what I can tell, we could probably get by just having get always return null;

This was enough to get react-native-vector-icons, which recently got new arch support, to work in storybook.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 98495ac:

Sandbox Source
react-native-web-examples Configuration

@necolas
Copy link
Owner

necolas commented Mar 27, 2023

Hi. I don't think TurboModuleRegistry is appropriate for web, as we don't use turbo modules for that platform. react-native-vector-icons etc should avoid trying to load turbo modules on web. Thanks

@necolas necolas closed this Mar 27, 2023
@johnf
Copy link
Author

johnf commented Mar 27, 2023

@necolas I figured it might be appropriate, given the equivalent exists for NativeModules. No problem, I'll create a PR for react-native-vector-icons

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants