-
-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Displaying timezone information in HTML report #960
Conversation
Thanks for doing this, and sorry for my silence. I'm curious why the timezone is important on the report? I have some concerns about the code. On my Mac, on 2.7, the timezone is shown as "+2000", but on 3.7, it's "-0400". I'm not that comfortable with maintaining the fallback code for format_local_datetime. How would you feel about displaying the timezone only for Python versions that can do it natively (3.6+)? |
Codecov Report
@@ Coverage Diff @@
## master #960 +/- ##
=======================================
Coverage 94.03% 94.04%
=======================================
Files 86 86
Lines 12102 12182 +80
Branches 1211 1224 +13
=======================================
+ Hits 11380 11456 +76
- Misses 588 590 +2
- Partials 134 136 +2
Continue to review full report at Codecov.
|
I have multiple CI servers that have different time zones, so I would like to know the exact time of the test report.
Sounds good. The backward compatible code is ugly, let's get rid of it :) |
* Displaying timezone information in HTML report * A helpber to format datetime with local timezone * No backward compatibility with older python versions
* Displaying timezone information in HTML report * A helpber to format datetime with local timezone * No backward compatibility with older python versions
Thanks! I merged it, and had to fix the test (sometimes time zones are -XXXX instead of +XXXX). |
This is available in coverage 5.2.1. |
No description provided.