Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

github-release command includes anchor of previous version #53

Closed
rodrigogiraoserrao opened this issue Jun 29, 2022 · 4 comments
Closed

Comments

@rodrigogiraoserrao
Copy link
Contributor

When creating/updating releases with scriv github-release, the release description contains the anchor of the previous release.

I will gladly tackle this, provided you are not in a hurry to fix this; otherwise, go ahead.

@nedbat
Copy link
Owner

nedbat commented Jun 30, 2022

Can you show me what you mean? I haven't noticed this in my uses: https://github.com/nedbat/dinghy/releases

@rodrigogiraoserrao
Copy link
Contributor Author

My CHANGELOG.md (note, it's a markdown changelog collected from markdown fragments) starts like this:

# Changelog

<!--scriv-insert-here-->

<a id='changelog-0.1.2'></a>
# 0.1.2 — 2022-06-30

## Added

- 100% code coverage.
- Code coverage reporting to tox.
- Tests to cover encoding and decoding that fails.

<a id='changelog-0.1.1'></a>
# 0.1.1 — 2022-06-25

## Added

- ...

Screenshot_3

My 0.1.2 release notes look like this;

## Added

- 100% code coverage.
- Code coverage reporting to tox.
- Tests to cover encoding and decoding that fails.

<a id='changelog-0.1.1'></a>

Screenshot_2

It looks like the changelog is just being truncated in the wrong place. My 0.1.1 release exhibits the same issue (it contains the anchor for the 0.1.0 heading).
However, these anchors are not visible in the release, only when you try to edit the release notes.

@nedbat
Copy link
Owner

nedbat commented Jul 24, 2022

This is fixed in commit 31b8a4b.

@nedbat nedbat closed this as completed Jul 24, 2022
@nedbat
Copy link
Owner

nedbat commented Jul 24, 2022

This is now released as part of scriv 0.16.0.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants