Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

scriv collect always creates changelog entry even if nothing has changed #55

Closed
sysid opened this issue Jul 31, 2022 · 3 comments
Closed

scriv collect always creates changelog entry even if nothing has changed #55

sysid opened this issue Jul 31, 2022 · 3 comments

Comments

@sysid
Copy link

sysid commented Jul 31, 2022

@nedbat, thanks for contributing this tool.

I observed a surprising behavior when running scriv collectseveral times in a row:
Every run of scriv collectcreates a new entry in changelog.md even without a new fragment or changed version number. This results in empty and redundant entries in changelog.md.

Without a new fragment I would not expect to get a new entry in changelog.md. Maybe I am missing something.
Regards, sysid
nedbat pushed a commit that referenced this issue Aug 2, 2022
fix: shouldn't change the changelog if there are no fragments. #55
d9c3826
nedbat pushed a commit that referenced this issue Aug 2, 2022
fix: collect should do nothing if there are no fragments. #55
5fedb64
@nedbat
Copy link
Owner

nedbat commented Aug 2, 2022

Oops, thanks! Fixed in 5fedb64

@nedbat nedbat closed this as completed Aug 2, 2022
@sysid
Copy link
Author

sysid commented Aug 3, 2022

Top, thks for the swift respone!

@nedbat
Copy link
Owner

nedbat commented Sep 18, 2022

This is now released as part of scriv 0.17.0.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nedbat @sysid