Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

act dind flag #2420

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

act dind flag #2420

wants to merge 2 commits into from

Conversation

ChristopherHX
Copy link
Contributor

Adds --dind flag, disabling this flag is causing errors :(

This makes the following work and mount $PWD correctly

Fixes #pod

on: push
jobs:
  test:
    runs-on: test
    steps:
    - uses: actions/checkout@v4
    - run: docker info
      shell: sh
    - run: docker run -v $PWD:$PWD --rm alpine:latest ls $PWD
      shell: sh

Could resolve #2393 or not, but not tested with podman host....

@ChristopherHX ChristopherHX requested a review from a team as a code owner August 11, 2024 15:51
Copy link
Contributor

github-actions bot commented Aug 11, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 4 0 0.03s
✅ REPOSITORY gitleaks yes no 2.3s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 9.07s
✅ REPOSITORY secretlint yes no 1.02s
✅ REPOSITORY trivy-sbom yes no 0.47s
✅ REPOSITORY trufflehog yes no 4.19s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link
Contributor

mergify bot commented Aug 11, 2024

@ChristopherHX this pull request has failed checks 🛠

@mergify mergify bot added the needs-work Extra attention is needed label Aug 11, 2024
Copy link

codecov bot commented Aug 11, 2024

Codecov Report

Attention: Patch coverage is 3.84615% with 25 lines in your changes missing coverage. Please review.

Project coverage is 76.35%. Comparing base (5a80a04) to head (ea7100f).
Report is 99 commits behind head on master.

Files Patch % Lines
pkg/runner/run_context.go 3.84% 24 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2420       +/-   ##
===========================================
+ Coverage   61.56%   76.35%   +14.79%     
===========================================
  Files          53       62        +9     
  Lines        9002     8180      -822     
===========================================
+ Hits         5542     6246      +704     
+ Misses       3020     1367     -1653     
- Partials      440      567      +127     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

mergify bot commented Aug 13, 2024

@ChristopherHX this pull request has failed checks 🛠

@ChristopherHX
Copy link
Contributor Author

I totally forget about exposing ports from container.

hijacking a docker-proxy binary with a script might be able to do the proxy logic in the job container to match expectations.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
needs-work Extra attention is needed size/M
Projects
None yet
1 participant