Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added options to mark a pull request as Approved or Needs Work #123

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tettaji
Copy link

@tettaji tettaji commented Apr 12, 2017

When set, this automatically marks a pull request as Approved or Needs Work if a build succeeds or fails, respectively.

@nitrocode
Copy link

nitrocode commented Nov 6, 2017

@tettaji nice PR! Thank you for the work.

@nemccarthy Hi Nathan. Do you think this PR can be merged into main branch? If not, what can be improved on to get it merged?

It would definitely help push Jenkins as more of an authority on our builds if it could set PRs to needs_work when the code breaks the build.

@missedone
Copy link

👍
I verified this PR in our Jenkins instance, it works like a charm.

@Macarse
Copy link

Macarse commented Nov 6, 2017

@tettaji do you mind squashing commits in this PR so it's easier to cherry-pick?

@tettaji tettaji force-pushed the feature/mark-status branch from 7506f12 to 65b230e Compare November 7, 2017 12:57
@tettaji
Copy link
Author

tettaji commented Nov 7, 2017

Thanks for the comments!

@Macarse sure, I've just squashed everything into one commit.

@dawidmalina
Copy link

dawidmalina commented Jan 27, 2018

When this can be merged?

@tettaji
Copy link
Author

tettaji commented Mar 29, 2018

It would be cool if this could be merged before its one year anniversary. :P

@Macarse
Copy link

Macarse commented Mar 29, 2018

hehe I ended up forking and use my own version by cherry-picking what I need.

@phschoen
Copy link

phschoen commented Jul 9, 2018

oh man still open? congrats to a pullrequest which is 16months open @nemccarthy

@batmat
Copy link

batmat commented Jan 21, 2019

Unmaintained repo, unrelated to the Jenkins Project FYI.
See #158

@tettaji
Copy link
Author

tettaji commented Jan 21, 2019

@batmat thanks for the heads up.

I haven't been using Jenkins for a while, but if anyone wants to fork this PR and submit it to the officially maintained repo, feel free to do so.

@dawidmalina
Copy link

@jakub-bochenski would be nice if you could take over this pull request as @tettaji have no more interest in doing it. But he is ok with taking his code.

@jakub-bochenski
Copy link

@dawidmalina I don't plan to work on this.

You can file a PR on https://github.com/jenkinsci/stash-pullrequest-builder-plugin/ if you want this integrated.
One thing I would ask for if you do is some more context for this change. Right now I don't see why would one need this instead of just requiring a passing build to merge a PR.

@mrdima
Copy link

mrdima commented Mar 13, 2019

I have an interest, I'll try add the PR to the jenkinsci version of this repo

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants