-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Added options to mark a pull request as Approved or Needs Work #123
base: master
Are you sure you want to change the base?
Conversation
@tettaji nice PR! Thank you for the work. @nemccarthy Hi Nathan. Do you think this PR can be merged into main branch? If not, what can be improved on to get it merged? It would definitely help push Jenkins as more of an authority on our builds if it could set PRs to needs_work when the code breaks the build. |
👍 |
@tettaji do you mind squashing commits in this PR so it's easier to cherry-pick? |
7506f12
to
65b230e
Compare
Thanks for the comments! @Macarse sure, I've just squashed everything into one commit. |
When this can be merged? |
It would be cool if this could be merged before its one year anniversary. :P |
hehe I ended up forking and use my own version by cherry-picking what I need. |
oh man still open? congrats to a pullrequest which is 16months open @nemccarthy |
Unmaintained repo, unrelated to the Jenkins Project FYI. |
@batmat thanks for the heads up. I haven't been using Jenkins for a while, but if anyone wants to fork this PR and submit it to the officially maintained repo, feel free to do so. |
@jakub-bochenski would be nice if you could take over this pull request as @tettaji have no more interest in doing it. But he is ok with taking his code. |
@dawidmalina I don't plan to work on this. You can file a PR on https://github.com/jenkinsci/stash-pullrequest-builder-plugin/ if you want this integrated. |
I have an interest, I'll try add the PR to the jenkinsci version of this repo |
When set, this automatically marks a pull request as Approved or Needs Work if a build succeeds or fails, respectively.