Moving check for new Pull Requests into separate thread pool #147
Conversation
… blocking cron thread (JENKINS-41336)
| @Override | ||
| public void run() { | ||
| try { | ||
| stashPullRequestsBuilder.run(); |
There was a problem hiding this comment.
Is it by intentention that all exceptions are ignored now?
There was a problem hiding this comment.
Let's say it is not intentional. Let me add the fix for this.
|
We have the plugin deployed, works properly with the fix and cron is working normally too. |
|
@darxriggs Is there anything I can do to make this PR merged? |
|
@kmoco2am I was an ordinary user of this plugin back in 2018 and tried to help make some progress with this pull request. Two years later it looks like the plugin is not maintained anymore. |
|
Sorry @darxriggs & @kmoco2am I'm no longer maintaining this as I no longer use Stash but I understand there are a lot of users. This plugin is being maintained by the upstream jenkis project. https://github.com/jenkinsci/stash-pullrequest-builder-plugin I have asked for volunteers a while back, but if either of you would like to be contributors and maintain this plugin I would be very greatful. Let me know and I'll add you to this repo as there are a few pending PRs |
|
Thanks for updating the README accordingly. |
Pull Request builder is using Jenkins cron thread to check for new pull requests in Stash and it is causing JENKINS-41336 on large instances. So this is an implementation of the same strategy which is used in Github Pull Request Builder plugin to offload the real check into own thread pool with limited size.