Added groups param to convolutions #223
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context:
There is a (tentatively) accepted pull request for adding grouped convolutions to nengo already. Before adding grouped convolutions to nengo-loihi it is neccessary to add grouped convolutions to nengo-dl.
Related Forum Posts
https://forum.nengo.ai/t/adding-a-groups-parameter-for-convolutions-in-nengo-loihi/2035/2
https://forum.nengo.ai/t/trying-to-understand-nengo-transforms-convolution/1844/4?u=mjurado3
Interactions with other PRs:
This change is dependent upon this pull requrest in the nengo repository: nengo/nengo#1684
How has this been tested?
This is tested through the test_conv in nengo_dl/tests/test_converter.py
How long should this take to review?
30 minutes if there are no additional features that should be added.
Where should a reviewer start?
Types of changes:
New-Feature: High Level addition of groups parameter to ConvertConv
Checklist: