Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add license and purchase link to getting started #29

Merged
merged 1 commit into from
Jun 21, 2019
Merged

Add license and purchase link to getting started #29

merged 1 commit into from
Jun 21, 2019

Conversation

bmorcos
Copy link
Contributor

@bmorcos bmorcos commented Jun 21, 2019

Motivation and context:

There was no mention of a license or any links from which to by one, now there is.

How long should this take to review?

  • Quick (less than 40 lines changed or changes are straightforward)

Where should a reviewer start?

Build the docs and take a look

Types of changes:

  • Non-code change (touches things like tests, documentation, build scripts)

Checklist:

  • I have read the CONTRIBUTING.rst document.
  • I have updated the documentation accordingly.
  • I have included a changelog entry.
  • N/A I have tested this with all supported devices.
  • N/A I have added tests to cover my changes.
  • N/A I have run the test suite locally and all tests passed.

Still to do:

@xchoo
Copy link
Member

xchoo commented Jun 21, 2019

I'm wondering if we should change the "NengoFPGA License" page heading to something else to avoid confusion between that and the NengoFPGA board licenses?

@xchoo
Copy link
Member

xchoo commented Jun 21, 2019

Or move it to a "Project information" group like in Nengo-DL?

@bmorcos
Copy link
Contributor Author

bmorcos commented Jun 21, 2019

I changed the software license heading... Unsure if we want to create a project section or not :/

@bmorcos
Copy link
Contributor Author

bmorcos commented Jun 21, 2019

I Made a new section like NengoDL, looks good!

- Add Project Information section to docs
  - Put license, contributing, and changelog in docs like NengoDL
@bmorcos bmorcos merged commit e97ba94 into master Jun 21, 2019
@bmorcos bmorcos deleted the buy-me branch July 2, 2019 12:41
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants