Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added a notebook example for setting neuron params #30

Merged
merged 1 commit into from
Jul 2, 2019
Merged

Conversation

bmorcos
Copy link
Contributor

@bmorcos bmorcos commented Jun 21, 2019

Motivation and context:

Elishai had requested an example for setting weights, so I figured we may as well publish a proper example of that.

How long should this take to review?

  • Average (neither quick nor lengthy)

Where should a reviewer start?

Run through the note new notebook locally to check functionality on both PYNQ and DE1. Also build the docs and take a look through those.

Types of changes:

  • Non-code change (touches things like tests, documentation, build scripts)

Checklist:

  • I have read the CONTRIBUTING.rst document.
  • I have updated the documentation accordingly.
  • I have included a changelog entry.
  • I have tested this with all supported devices.
  • N/A I have added tests to cover my changes.
  • N/A I have run the test suite locally and all tests passed.

- Fixes 28
- Also renumbered examples in the gui folder to start at 0
  - Updated example page in docs with new filenames
  - Basically didn't want to have the notebook examples go 0, 1, 5
    so I made the number separate for gui and notebook examples
@bmorcos bmorcos merged commit 2e55747 into master Jul 2, 2019
@bmorcos bmorcos deleted the set-enc-eg branch July 2, 2019 12:49
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants