Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add maximum model size spec to docs #31

Merged
merged 1 commit into from
Jul 3, 2019
Merged

Add maximum model size spec to docs #31

merged 1 commit into from
Jul 3, 2019

Conversation

bmorcos
Copy link
Contributor

@bmorcos bmorcos commented Jul 2, 2019

Motivation and context:

Chris noticed this isn't listed anywhere... now it is!

Interactions with other PRs:

nengo-pynq!18
nengo-de1!14

How long should this take to review?

  • Quick (less than 40 lines changed or changes are straightforward)

Where should a reviewer start?

Build the docs and take a look at the new section.

Types of changes:

  • Non-code change (touches things like tests, documentation, build scripts)

Checklist:

  • I have read the CONTRIBUTING.rst document.
  • I have updated the documentation accordingly.
  • I have included a changelog entry.
  • N/A I have tested this with all supported devices.
  • N/A I have added tests to cover my changes.
  • N/A I have run the test suite locally and all tests passed.

Still to do:

These docs now reference pages that don't exist yet, so we must merge in the hardware docs first.

  • Merge nengo-de1
  • Merge nengo-pynq

Copy link
Member

@xchoo xchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should put the specific details into the respective board documentation.

- Also fixed some line wrapping in the usage.rst file while I was in there
@bmorcos bmorcos merged commit 6fccfdb into master Jul 3, 2019
@bmorcos bmorcos deleted the model-spec branch July 3, 2019 13:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants