Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Update to new theme #32

Merged
merged 1 commit into from
Jul 30, 2019
Merged

Update to new theme #32

merged 1 commit into from
Jul 30, 2019

Conversation

bmorcos
Copy link
Contributor

@bmorcos bmorcos commented Jul 30, 2019 •
edited
Loading

Motivation and context:

Update to new sphinx theme

How long should this take to review?

  • Quick (less than 40 lines changed or changes are straightforward)

Where should a reviewer start?

Build the docs and take a look

Types of changes:

  • Non-code change (touches things like tests, documentation, build scripts)

Checklist:

  • I have read the CONTRIBUTING.rst document.
  • I have updated the documentation accordingly.
  • I have included a changelog entry.
  • N/A I have tested this with all supported devices.
  • N/A I have added tests to cover my changes.
  • N/A I have run the test suite locally and all tests passed.

xchoo
xchoo requested changes Jul 30, 2019
View reviewed changes
Copy link
Member

@xchoo xchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some formatting changes requested.

xchoo
xchoo requested changes Jul 30, 2019
View reviewed changes
Copy link
Member

@xchoo xchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 minor change. Tabbing issue.

@bmorcos
Update to new theme
04d1911 
- Removed a lot of indentation because it rendered as block quotes
- Change to padded, transparent, png images of the boards
- Remove extra rows from tables (no longer required to draw borders with new
  theme)
@bmorcos bmorcos merged commit 04d1911 into master Jul 30, 2019
@bmorcos bmorcos deleted the new-docs-theme branch July 30, 2019 19:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@xchoo xchoo xchoo approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bmorcos @xchoo