Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Remove unused seed from builder #58

Merged
merged 1 commit into from
Apr 22, 2020
Merged

Remove unused seed from builder #58

merged 1 commit into from
Apr 22, 2020

Conversation

bmorcos
Copy link
Contributor

@bmorcos bmorcos commented Apr 21, 2020 •
edited
Loading

Interactions with other PRs:

We can cleanup the network builder test #55 slightly when rebased onto this change.

How has this been tested?

Ran the tests from the testing branch on this change

How long should this take to review?

  • Quick (less than 40 lines changed or changes are straightforward)

Types of changes:

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have read the CONTRIBUTING.rst document.
  • N/A I have updated the documentation accordingly.
  • I have included a changelog entry.
  • I have tested this with all supported devices.
  • N/A I have added tests to cover my changes.
  • I have run the test suite locally and all tests passed.

@bmorcos bmorcos merged commit 4922252 into master Apr 22, 2020
@bmorcos bmorcos deleted the remove-seed branch April 22, 2020 20:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@xchoo xchoo xchoo approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bmorcos @xchoo