Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Export travis job number #63

Merged
merged 1 commit into from
Apr 28, 2020
Merged

Export travis job number #63

merged 1 commit into from
Apr 28, 2020

Conversation

bmorcos
Copy link
Contributor

@bmorcos bmorcos commented Apr 28, 2020 •
edited
Loading

Motivation and context:

The TRAVIS_JOB_NUMBER variable is never set on the remote for the docs build, so if a build fails the failed file flag has an unexpected name and is not found by the local Travis job.

How long should this take to review?

  • Quick (less than 40 lines changed or changes are straightforward)

Where should a reviewer start?

  • Non-code change (touches things like tests, documentation, build scripts)

Checklist:

  • I have read the CONTRIBUTING.rst document.
  • N/A I have updated the documentation accordingly.
  • I have included a changelog entry.
  • N/A I have tested this with all supported devices.
  • N/A I have added tests to cover my changes.
  • N/A I have run the test suite locally and all tests passed.

xchoo
xchoo requested changes Apr 28, 2020
View reviewed changes
Copy link
Member

@xchoo xchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build is failing on success now. XD
I think removing the exe from the ssh call should fix it.

@bmorcos
Export travis job number
37c3369 
- This is used in the remote docs script to preventi
  failed builds from pushing docs.
- Also added exe wrapper to the scp failed_file command
@bmorcos bmorcos merged commit 37c3369 into master Apr 28, 2020
@bmorcos bmorcos deleted the docs-fix branch April 28, 2020 17:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@xchoo xchoo xchoo requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bmorcos @xchoo