Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Expose committee address #3154

Merged
merged 67 commits into from
Mar 2, 2024
Merged

Expose committee address #3154

merged 67 commits into from
Mar 2, 2024

Conversation

shargon
Copy link
Member

@shargon shargon commented Feb 22, 2024 •
edited
Loading

Close #3153
Require #2942

shargon and others added 30 commits November 5, 2023 13:35
@shargon
Update manifest
24b181f
@shargon
Fix comment
3c6a1f0
@shargon
Format & fix methods
a5772bc
@shargon
Fix new
95335e0
@shargon
Initialize storage fixes
7ae51e1
@shargon
Fix IsInitializeBlock
22d72b5
@shargon
Fix update
c7602c6
@shargon
Fix GetContractState
b573a00
@shargon
Optimize
3adddd2
@shargon
Fix first invoke without sync
984d3d7
@shargon
Remove current methods
6341bad
@shargon
Clean usings
4f59c43
@shargon
Improve reading Initialize
c85a1cc
@shargon
Clean OnManifestCompose
2490280
@shargon
Use cache for all native contracts
47317ee
@shargon
Fix ut
8fd8fc2
@shargon
Move cache to ApplicationEngine
7ba6274
@shargon
Clean code
67a9364
@shargon
Allow nullable attribute
8eb82db
@Jim8y
Update src/Neo/SmartContract/Native/ContractEventAttribute.cs
8667047
@Jim8y
Merge branch 'master' into update-native-contracts
5f41acf
@shargon
Add base call
ed33b32
@shargon
Merge branch 'update-native-contracts' of https://github.com/neo-proj…
eea7324 
…ect/neo into update-native-contracts
@shargon
Fix one #2941 (comment)
594c2e6
@shargon
Fix IsInitializeBlock #2941 (comment)
64e5cfc
@shargon
Add ContractEventAttribute constructors for ActiveIn
1b210ce
@shargon
Merge branch 'master' into update-native-contracts
5bb42d2
@shargon
Ensure ommited hfs
690b5d4
@shargon
Rename
8cef6ce
@shargon
Case insensitive hf config
f114982
@Jim8y Jim8y added Waiting for Review Blocked This issue can't be worked at the moment Help Wanted We suggest a careful read at https://docs.neo.org/. However, fell free to further discuss the topic. labels Feb 24, 2024
@superboyiii
Copy link
Member

superboyiii commented Mar 1, 2024 •
edited
Loading

@shargon Looks like GetCommittee() and GetCommittee() doesn't differ a lot on execution time. May be 1 << 16 is enough?
8ec6be8d17a9e686680d22b2563fb31
I add StopWatch in OnInvokeWithResult() of CLI
bac5e00eb9b6d5a12db38c15d4bc7c3

@shargon shargon merged commit d3c9175 into master Mar 2, 2024
6 checks passed
@shargon shargon deleted the core-expose-committee-addr branch March 2, 2024 00:01
@AnnaShaleva AnnaShaleva mentioned this pull request Mar 3, 2024
Closed
AliceInHunterland added a commit to nspcc-dev/neo-go that referenced this pull request Mar 19, 2024
@AliceInHunterland
native: add getCommitteeAddress method
94869d9 
Port neo-project/neo#3154.

Close #3334

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
@AliceInHunterland AliceInHunterland mentioned this pull request Mar 19, 2024
Merged
AliceInHunterland added a commit to nspcc-dev/neo-go that referenced this pull request Mar 19, 2024
@AliceInHunterland
native: add getCommitteeAddress method
f39d295 
Port neo-project/neo#3154.

Close #3334

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland added a commit to nspcc-dev/neo-go that referenced this pull request Mar 20, 2024
@AliceInHunterland
native: add getCommitteeAddress method
29d4f7c 
Port neo-project/neo#3154.

Close #3334

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland added a commit to nspcc-dev/neo-go that referenced this pull request Mar 22, 2024
@AliceInHunterland
native: add getCommitteeAddress method
77c921a 
Port neo-project/neo#3154.

Close #3334

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland added a commit to nspcc-dev/neo-go that referenced this pull request Mar 22, 2024
@AliceInHunterland
native: add getCommitteeAddress method
14a6104 
Port neo-project/neo#3154.

Close #3334

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland added a commit to nspcc-dev/neo-go that referenced this pull request Mar 22, 2024
@AliceInHunterland
native: add getCommitteeAddress method
e0328cc 
Port neo-project/neo#3154.

Close #3334

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AnnaShaleva added a commit to nspcc-dev/neo-go that referenced this pull request Apr 8, 2024
@AnnaShaleva
config, native: introduce Cockatrice hard-fork
268ea28 
With all associated native API changes ported from
neo-project/neo#2925 and
neo-project/neo#3154.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva added a commit to nspcc-dev/neo-go that referenced this pull request Apr 9, 2024
@AnnaShaleva
config, native: introduce Cockatrice hard-fork
65a2702 
With all associated native API changes ported from
neo-project/neo#2925 and
neo-project/neo#3154.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva added a commit to nspcc-dev/neo-go that referenced this pull request Apr 9, 2024
@AnnaShaleva
config, native: introduce Cockatrice hard-fork
f9c91f0 
With all associated native API changes ported from
neo-project/neo#2925 and
neo-project/neo#3154.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva added a commit to nspcc-dev/neo-go that referenced this pull request Apr 10, 2024
@AnnaShaleva
config, native: introduce Cockatrice hard-fork
05581c9 
With all associated native API changes ported from
neo-project/neo#2925 and
neo-project/neo#3154.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva added a commit to nspcc-dev/neo-go that referenced this pull request Apr 18, 2024
@AnnaShaleva
config, native: introduce Cockatrice hard-fork
5c4eb52 
With all associated native API changes ported from
neo-project/neo#2925 and
neo-project/neo#3154.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva added a commit to nspcc-dev/neo-go that referenced this pull request Apr 18, 2024
@AnnaShaleva
config, native: introduce Cockatrice hard-fork
0085aad 
With all associated native API changes ported from
neo-project/neo#2925 and
neo-project/neo#3154.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva added a commit to nspcc-dev/neo-go that referenced this pull request Apr 18, 2024
@AnnaShaleva
config, native: introduce Cockatrice hard-fork
21094c7 
With all associated native API changes ported from
neo-project/neo#2925 and
neo-project/neo#3154.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva added a commit to nspcc-dev/neo-go that referenced this pull request Apr 25, 2024
@AnnaShaleva
config, native: introduce Cockatrice hard-fork
5c75ee1 
With all associated native API changes ported from
neo-project/neo#2925 and
neo-project/neo#3154.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@vncoelho vncoelho vncoelho approved these changes

@roman-khimov roman-khimov roman-khimov approved these changes

@superboyiii superboyiii superboyiii approved these changes

@Jim8y Jim8y Awaiting requested review from Jim8y

Assignees

@superboyiii superboyiii

Labels
Blocked This issue can't be worked at the moment Help Wanted We suggest a careful read at https://docs.neo.org/. However, fell free to further discuss the topic. Waiting for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make public GetCommitteeAddress
5 participants
@shargon @superboyiii @vncoelho @roman-khimov @Jim8y