Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fixes #4080: Add Pinecone and Milvus support #4088

Merged
merged 4 commits into from
May 29, 2024
Merged

Fixes #4080: Add Pinecone and Milvus support #4088

merged 4 commits into from
May 29, 2024

Conversation

vga91
Copy link
Collaborator

@vga91 vga91 commented May 27, 2024

Fixes #4080

  • Added Pinecone and Milvus procedures, consistently with the other vector ones.
  • Renamed the previous PineconeTest to PineconeCustomTest (which leverages the apoc.vectordb.custom* procedures)
  • Added collection parameter to the VectorEmbeddingHandler.java method, which is used by the Milvus body request

Get the vectors with the specified `ids`.
The default endpoint is `<hostOrKey param>/vectors/fetch`.
| apoc.vectordb.pinecone.query(hostOrKey, index, vector, filter, limit, $config) |
Retrieve closest vectors the the defined `vector`, `limit` of results, in the index with the name specified in the 2nd parameter, and optionally creates/updates neo4j entities.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the last part of the description needs to be removed as this moved to the queryAndUpdate proc

[0.2, 0.1, 0.9, 0.7],
{},
5,
{ mapping: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

old mapping syntax

})
----

which populates the two relationships as: `()-[:TEST {myId: 'one', city: 'Berlin', vect: [vector1]}]-()`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how does it know from the mapping config that it is meant to update a relationship?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of relType: 'TEST' mapping config, instead of nodeLabel: 'Test'

Copy link
Member

@jexp jexp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM please look at my comments for the query example with mapping + outdated syntax in dcos

@vga91 vga91 merged commit 5f6d37b into dev May 29, 2024
5 checks passed
@vga91 vga91 deleted the issue_4080 branch May 29, 2024 07:02
vga91 added a commit that referenced this pull request May 29, 2024
* Fixes #4080: Add Pinecone and Milvus support

* small code refactoring

* changes review

* fix PineconeTest without env vars
vga91 added a commit that referenced this pull request Dec 18, 2024
* Fixes #4080: Add Pinecone and Milvus support

* small code refactoring

* changes review

* fix PineconeTest without env vars
vga91 added a commit that referenced this pull request Dec 19, 2024
* Fixes #4080: Add Pinecone and Milvus support

* small code refactoring

* changes review

* fix PineconeTest without env vars
vga91 added a commit that referenced this pull request Jan 15, 2025
* Fixes #4080: Add Pinecone and Milvus support

* small code refactoring

* changes review

* fix PineconeTest without env vars
vga91 added a commit that referenced this pull request Jan 16, 2025
* Fixes #4080: Add Pinecone and Milvus support

* small code refactoring

* changes review

* fix PineconeTest without env vars
vga91 added a commit that referenced this pull request Jan 21, 2025
…d added Milvus and Pinecone support (#4264)

* [NOID] Fixes #4087: Add vector info procedures (#4142)

* [NOID] Fixes #4080: Add Pinecone and Milvus support (#4088)

* [NOID] Fixes #4231: The apoc.vectordb.milvus.query* and apoc.vectordb.weaviate.query* procedures should get the fields config from metadataKey if present (#4241)

* Fixes #4231: The apoc.vectordb.milvus.query* and apoc.vectordb.weaviate.query* procedures should get the fields config from metadataKey if present


* [NOID] Fixes #4231: The apoc.vectordb.milvus.query* and apoc.vectordb.weaviate.query* procedures should get the fields config from metadataKey if present (#4241)

* Fixes #4231: The apoc.vectordb.milvus.query* and apoc.vectordb.weaviate.query* procedures should get the fields config from metadataKey if present
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants