Skip to content
This repository was archived by the owner on Sep 3, 2021. It is now read-only.

Fix integration tests #300

Merged
merged 1 commit into from
Sep 3, 2019
Merged

Conversation

danielrearden
Copy link
Contributor

The fail method in ava only accepts a String -- if anything else is passed to it, it blows up with a cryptic "The assertion message must be a string" message. This fixes these calls so that if a test actually fails, the error that caused the test to fail is shown rather than the aforementioned message.

This change also adds a reminder to install APOC to the contributing guidelines.

@codecov-io
Copy link

Codecov Report

Merging #300 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #300   +/-   ##
=======================================
  Coverage   95.47%   95.47%           
=======================================
  Files          10       10           
  Lines        2345     2345           
=======================================
  Hits         2239     2239           
  Misses        106      106

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90bd912...3d1a90b. Read the comment docs.

1 similar comment
@codecov-io
Copy link

codecov-io commented Aug 30, 2019

Codecov Report

Merging #300 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #300   +/-   ##
=======================================
  Coverage   95.47%   95.47%           
=======================================
  Files          10       10           
  Lines        2345     2345           
=======================================
  Hits         2239     2239           
  Misses        106      106

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90bd912...3d1a90b. Read the comment docs.

@johnymontana
Copy link
Contributor

Thanks, @danielrearden!

@johnymontana johnymontana merged commit 03b0089 into neo4j-graphql:master Sep 3, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants