Skip to content
This repository was archived by the owner on Sep 3, 2021. It is now read-only.

Schema augmentation refactor #322

Closed
wants to merge 39 commits into from
Closed

Schema augmentation refactor #322

wants to merge 39 commits into from

Conversation

michaeldgraham
Copy link
Collaborator

Hello everyone!

This PR has been in the works for a while, and I've appreciated your patience. It almost entirely rewrites the augmentation process and is meant to only replicate current behavior. Still, as a result of new design, there are a few changes that might go noticed:

  1. Types are generated in a different order. Augmentation testing has been updated to compare schemas regardless of ordering differences.
  2. All type extensions are now persisted.
  3. Default @relation type directives are no longer generated (an undocumented behavior...), although default relationship name arguments still are.

It is my hope that this design will enable a smoother development of various bug fixes and features that depend upon the augmentation process. I would love any feedback you might have! 🙂🚀

@codecov-io
Copy link

codecov-io commented Oct 9, 2019

Codecov Report

Merging #322 into master will increase coverage by 0.85%.
The diff coverage is 97.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #322      +/-   ##
==========================================
+ Coverage    95.4%   96.25%   +0.85%     
==========================================
  Files          10       23      +13     
  Lines        2350     2565     +215     
==========================================
+ Hits         2242     2469     +227     
+ Misses        108       96      -12
Impacted Files Coverage Δ
src/augment/ast.js 100% <100%> (ø)
src/augment/input-values.js 100% <100%> (ø)
src/augment/types/node/node.js 100% <100%> (ø)
src/augment/types/node/query.js 100% <100%> (ø)
src/augment/types/node/mutation.js 100% <100%> (ø)
src/augment/types/types.js 100% <100%> (ø)
src/translate.js 98.64% <100%> (ø) ⬆️
src/utils.js 94.59% <100%> (+1.37%) ⬆️
src/augment/fields.js 100% <100%> (ø)
src/auth.js 72% <100%> (-6.73%) ⬇️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70e6966...730c22a. Read the comment docs.

johnymontana added a commit that referenced this pull request Oct 22, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants