This repository was archived by the owner on Sep 3, 2021. It is now read-only.
Fix for incorrect behavior in filters #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FIx for incorrect behaviour in _some filtering for filters on types below the root. Variable created from type-name is replaced with the variableName the function receives. A variable that is derived from typename means that any path-selection will be performed using the full set of nodes of this type as left set. When filters are defined on relationships we actually want to filter on the set that is represented on the parent relationship. See issue #326
|
The same naming convention is occasionally used for both node-variables and relationship-variables. Needs some additional fixing to prevent name collisions. |
Solving som variable naming conflicts causing some of the tests to break
Codecov Report
@@ Coverage Diff @@
## master #330 +/- ##
==========================================
+ Coverage 96.25% 96.26% +<.01%
==========================================
Files 23 23
Lines 2565 2568 +3
==========================================
+ Hits 2469 2472 +3
Misses 96 96
Continue to review full report at Codecov.
|
|
Thanks @trondaal! |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIx for incorrect behaviour when filters are defined on types below the root. Variable created from type-name is replaced with the variableName the function receives which more accurately represents the set that the filter should be applied to. See issue #326